[NFC] Cleanup function templates implementation. Address post-commit review comments from #33053. #35416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
approved these changes
Jan 18, 2021
gribozavr
changed the title
|
@swift-ci please smoke test. |
… review comments from swiftlang#33053. Addresses the post-commit review comments from swiftlang#33053. Just re-naming, commenting, and some other small cleanups, nothing functionally different.
zoecarver
force-pushed
the
cxx/cleanup-function-template-post-commit
branch
from
111b1fe to
c4da497
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test macOS. |
|
@swift-ci please smoke test Windows. |
1 similar comment
|
@swift-ci please smoke test Windows. |
|
@swift-ci please smoke test macOS. |
zoecarver
added a commit
to zoecarver/swift
that referenced
this pull request
Jan 31, 2021
c4da497 (swiftlang#35416) changed the names of several member templates, this commit fixes the disabled test to use those new names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the post-commit review comments from #33053. Just re-naming, commenting, and some other small cleanups, nothing functionally different.