Sema: Fix inherited designated init synthesis when there's a 'where' clause but no new generic parameters #35727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clause but no new generic parameters SE-0267 allows where clauses on declarations without their own generic parameters, which means we can longer assume that if getGenericParams() returns nullptr on a constructor, then the constructor has the same generic signature as its parent class. Instead, explicitly compare the superclass constructor's generic signature with that of the superclass, and if they don't match, compute a new generic signature for the override. Fixes https://bugs.swift.org/browse/SR-14118 / rdar://73764827.
slavapestov
force-pushed
the
inherited-designated-init-with-where-clause
branch
from
79ee071 to
3dfbf15
Compare
|
@jckarter Thanks for diagnosing the issue! |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0267 allows where clauses on declarations without their own generic
parameters, which means we can longer assume that if getGenericParams()
returns nullptr on a constructor, then the constructor has the same
generic signature as its parent class.
Instead, explicitly compare the superclass constructor's generic
signature with that of the superclass, and if they don't match,
compute a new generic signature for the override.
Fixes https://bugs.swift.org/browse/SR-14118 / rdar://73764827.