IRGen: Only emit PragmaCommentDecls if building for Windows, or LTO is enabled [5.4] #35796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s enabled clang::DeclContext::decls_begin() deserializes all the pre-compiled headers imported into the current translation unit, which is expensive. Workaround this by disabling the emission of PragmaCommentDecls unless we're building for a Windows target, or LTO is enabled. A better fix would be to serialize a separate index for PragmaCommentDecls so that they can be deserialized without deserializing everything else. I filed rdar://problem/74036099 to track the longer-term fix. Fixes rdar://problem/73951264.
|
@swift-ci Please test |
slavapestov
changed the title
|
Original: #35747 |
airspeedswift
approved these changes
Feb 5, 2021
AnthonyLatsis
added
swift 5.4
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang::DeclContext::decls_begin() deserializes all the pre-compiled headers
imported into the current translation unit, which is expensive.
Workaround this by disabling the emission of PragmaCommentDecls unless we're
building for a Windows target, or LTO is enabled.
A better fix would be to serialize a separate index for PragmaCommentDecls
so that they can be deserialized without deserializing everything else.
I filed rdar://problem/74036099 to track the longer-term fix.
Fixes rdar://problem/73951264.