[build] Add flags to allow skipping rebuilding the corelibs #38673
Conversation
|
@CodaFi, interested in this pull? |
|
@drexin, would you review? |
|
@swift-ci please test |
|
Build failed |
|
Oh, I only tested on linux, didn't realize my expanded test would fail on macOS. I will split libdispatch and Foundation off into a non-Darwin test. |
utils/build-script-impl
Outdated
| # The Swift project might have been changed, but CMake might | ||
| # not be aware and will not rebuild. | ||
| echo "Cleaning the XCTest build directory" | ||
| call rm -rf "${XCTEST_BUILD_DIR}" |
There was a problem hiding this comment.
This is currently only removed for non-Darwin, mistake? I see llbuild is removed by default for all OSs, I can move this above so it's removed for Darwin too, then this new flag will keep it for both.
There was a problem hiding this comment.
Moved this up so that this build directory is cleaned by default on macOS too, which is now tested by the updated test.
|
Split the test up and made sure XCTest is cleaned up on macOS too. |
|
@drexin, would you run this through the CI again? |
|
@swift-ci test |
|
Build failed |
Add three new flags, '--skip-clean-libdispatch', '--skip-clean-foundation', and '--skip-clean-xctest', that leave the previous builds of those products in place.
|
Rebased because #38885 moved a lot of code to a different file and disabled the new test on all Darwin platforms now. |
|
@artemcm, this should pass the CI now. |
|
@CodaFi, would you run this through the CI? |
|
@swift-ci please test |
|
Passed all CI except Windows, whose CI may be stuck. |
|
Ping, passed CI, ready for merge. |
|
@artemcm, anything holding back getting this merged? |
|
@swift-ci please test and merge |
|
We are seeing failure on CI: Changes to |
|
Huh, that passed the macOS CI though. I will disable the XCTest portion for Darwin platforms, pull forthcoming. |
Add three new flags,
--skip-clean-libdispatch,--skip-clean-foundation, and--skip-clean-xctest, that leave the previous builds of those products in place.I've been using a crude version of this patch for years when I'm iterating on one of the later products and don't want the corelibs rebuilt each time.
@edymtt, this is a follow-on to #36686, where you mentioned this is already done for XCTest, but it isn't. Mind reviewing?