[build-script] Create 'buildbot_linux' preset to reduce duplication #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ubuntu 14.04 preset existed to skip building Foundation due to unavailable ICU versions. The problem was corrected, but the comment and preset duplication of 'buildbot_linux_*' in build-presets.ini remained. This change adds a 'buildbot_linux' preset as the primary Linux preset and changes 'buildbot_linux_*' to use it as a mixin. Implemented as discussed with Dmitri Gribenko on swift-dev.
|
Looks good to me. |
emish
added a commit
that referenced
this pull request
Dec 10, 2015
[build-script] Create 'buildbot_linux' preset to reduce duplication
|
Thanks! |
|
@eosrei Thanks! |
13rac1
added a commit
to 13rac1/docker-swift-dev-buildbot
that referenced
this pull request
Dec 10, 2015
The original buildbot_linux_1404 and buildbot_linux1510 presets had become the same. I refactored build-presets.ini to create a new primary buildbot_linux preset. More details: swiftlang/swift#403
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Fix the signature of _dispatch_install_thread_detach_callback()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ubuntu 14.04 preset existed to skip building Foundation due to
unavailable ICU versions. The problem was corrected, but the
comment and preset duplication of 'buildbot_linux_*' in
build-presets.ini remained.
This change adds a 'buildbot_linux' preset as the primary Linux
preset and changes 'buildbot_linux_*' to use it as a mixin.
Implemented as discussed with Dmitri Gribenko on swift-dev.