Skip to content

Add a regression test for https://bugs.swift.org/browse/SR-15790 #41094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@philipturner
Copy link
Contributor

@slavapestov since you mentioned Richard Wei in the old thread, could we continue our conversation about crash_6 here temporarily? That should prevent polluting the old thread.

@philipturner
Copy link
Contributor

I just added the crash to my repository. It looks very similar to crash_2.swift. Given that they were on different toolchains, they might be the same one. However, their stack traces look nothing alike. @BradLarson said the following about crash_2 in JIRA:

For your crash_2 case, I think that's another manifestation of SR-15666. If I'm interpreting that right, I think these are cases where the function really isn't differentiable, but a diagnostic to that effect is missing and thus the assertion failure. In the cases where I hit this, the code wouldn't work to begin with, so it hadn't been a high priority to fix. I just filed that reproducer because I had it on hand.

I can't fully tell whether this is the same as the bug mentioned in SR-15666 or even related to it. It also seems like there isn't anything directly related to AutoDiff in the stack trace for crash_6. Could you investigate this?

@philipturner
Copy link
Contributor

Thanks for helping me out! I was worried that the AutoDiff bugs were intrinsically tied to RequirementMachine, and I would have to simultaneously patch AutoDiff and RequirementMachine. Now that I know they're all encapsulated within AutoDiff, there's less work to do.

@philipturner
Copy link
Contributor

#40812

@swift-ci swift-ci merged commit 2fe4417 into swiftlang:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants