[cmake] Allow overriding Clang resource symlink target #41301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with a prebuilt Clang, the changes introduced in swiftlang#40707 supposed that the toolchain was in its final path. When building in stages (first the toolchain, then the standard library), the toolchain might not be in the final path, and the created symlink will point to a machine-local path that does not make sense. The changes introduced should not modify the existing behaviour introduced by swiftlang#40707, but should allow customizing the final installation target using the CMake cached variable for those setups that need the flexibility.
|
@swift-ci please smoke test |
finagolfin
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Obviously my pull wouldn't work for the scenario you describe, just like the previous configuration didn't handle it, but I figured that would take later modification, as in the instructions for my Android SDKs. This pull seems a good way to configure that when building instead, for the cases when you know the final deployment path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with a prebuilt Clang, the changes introduced in #40707
supposed that the toolchain was in its final path.
When building in stages (first the toolchain, then the standard
library), the toolchain might not be in the final path, and the created
symlink will point to a machine-local path that does not make sense.
The changes introduced should not modify the existing behaviour
introduced by #40707, but should allow customizing the final
installation target using the CMake cached variable for those setups
that need the flexibility.
/cc @buttaface