Skip to content

[ConstraintSystem] Add support for expression patterns #41570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 26, 2022

  • Add a new CTP_ExprPattern contextual type and augment SolutionApplicationTarget
    to handle expressions originated from expression patterns.

  • Refactor pre-check to be able to deal with solution application targets

These are the preliminary changes to start type-checking expression patterns in the solver
when they appear in result builders and multi-statement closures.

…tern

This makes it possible to associate expression with its parent pattern.
Since `SolutionApplicationTarget` could represent whole statement
or pattern with multiple expressions, it makes sense to add a dedicated
method to pre-check everything together.
@xedin xedin requested a review from hborla February 26, 2022 00:58
@xedin
Copy link
Contributor Author

xedin commented Feb 26, 2022

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Feb 27, 2022

@swift-ci please smoke test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Feb 27, 2022

@swift-ci please test Linux platform

@xedin xedin merged commit 5ec5ffc into swiftlang:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants