[OSLog] Remove the dependency on _Concurrency
#41644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Concurrency is not used in the module, and having it as a dependency causes a ninja error when trying to build stdlib without `-D SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY=YES`: ``` ninja: error: 'stdlib/private/OSLog/swift_Concurrency-swiftmodule-macosx-arm64', needed by 'stdlib/private/OSLog/OSX/arm64/OSLogTestHelper.o', missing and no known rule to make it ```
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
bro4all
approved these changes
Mar 3, 2022
zoecarver
approved these changes
Mar 3, 2022
|
@swift-ci please build toolchain Linux |
|
@swift-ci please build toolchain Linux platform |
2 similar comments
|
@swift-ci please build toolchain Linux platform |
|
@swift-ci please build toolchain Linux platform |
|
The failure on Linux is unrelated, and this change only affects Darwin toolchains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Concurrency is not used in the module, and having it as a dependency causes a ninja error when trying to build stdlib without
-D SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY=YES: