Skip to content

[SourceKit] Report comment tags in 'indexsource' request #41681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 5, 2022

Comment tags weren't handled at all in SourceKit's request.indexsource request.

rdar://88728047 https://bugs.swift.org/browse/SR-15845

Comment tags weren't handled at all in SourceKit's 'request.indexsource'
request.

rdar://88728047
@rintaro
Copy link
Member Author

rintaro commented Mar 5, 2022

@swift-ci Please smoke test

@rintaro rintaro requested a review from bnbarham March 5, 2022 00:15
@@ -721,9 +721,12 @@ UIdent SwiftLangSupport::getUIDForSymbol(SymbolInfo sym, bool isRef) {
case SymbolKind::Module:
return KindRefModule;

case SymbolKind::CommentTag:
return KindCommentTag;

default:
// TODO: reconsider whether having a default case is a good idea.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the TODO now (it was a bad idea 😆)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this TODO because we still have the default case.

@rintaro rintaro merged commit 931449b into swiftlang:main Mar 7, 2022
@rintaro rintaro deleted the sourcekit-commenttag-rdar88728047 branch March 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants