[AutoDiff] Introduce regression test for SR-15849 #41717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @BradLarson |
|
@swift-ci Please test. |
BradLarson
changed the title
|
Transcribing context here for reference: SR-15849 has been impacting our internal code for a few months. Philip was able to isolate a single-file reproducer in this test case, which we had been using to diagnose the issue. In the process of doing so, the issue stopped reproducing in top-of-tree Swift. My speculation is that PR #41294 is what ended up preventing the assertion failure we had been seeing, but it's still being investigated. To prevent against a recurrence of the issue, it seemed like a good idea to put in place a regression test based in the reproducer Philip isolated from the Swift for TensorFlow codebase. This is that test. |
|
Thanks @BradLarson for the ping. |
rxwei
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #41437 for the relevant discussion. This test passes when rebased onto main. The previous pull request had to be closed because of a technical error.