[test] Small lit cleanups #41741
Merged
[test] Small lit cleanups #41741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, integrate its configuration into the preexisting target if ladders, where it belongs.
…ect spelling of DYLD_LIBRARY_PATH Instead of setting a random subset of `DYLD_LIBRARY_PATH`, `LD_LIBRARY_PATH`, `SIMCTL_CHILD_DYLD_LIBRARY_PATH`, `REMOTE_RUN_CHILD_DYLD_LIBRARY_PATH`, and `REMOTE_RUN_CHILD_LD_LIBRARY_PATH` in each `target_run` configuration, simply arrange for the single correct variable name to be in `config.target_library_path_var`, and set it only once. This should remove irrelevant environment variables from test logs, making them a little less confusing.
|
@swift-ci test |
This will be very helpful while debugging CI issues.
|
@swift-ci test |
swift-ci
pushed a commit
that referenced
this pull request
May 31, 2022
… natively on Android This broke in #41741, putting it back the way it was.
amritpan
pushed a commit
to amritpan/swift
that referenced
this pull request
Jun 10, 2022
… natively on Android This broke in swiftlang#41741, putting it back the way it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly refactors how we set DYLD_LIBRARY_PATH/LD_LIBRARY_PATH in the
%target-runpattern, so that we only set a single variable that is correct for the target platform and has the appropriate prefix (SIMCTL_CHILD_,IOS_CHILD_,REMOTE_RUN_CHILD_or nothing at all, depending on Various Things).More importantly, this also improves what gets logged to build output, hopefully helping me to track down a potential configuration issue in some CI bots.
rdar://89786892