Skip to content

[Distributed] Remove mangled names from API, move to RemoteCallTarget and pretty print it #41803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2022
Merged

[Distributed] Remove mangled names from API, move to RemoteCallTarget and pretty print it #41803

merged 5 commits into from
Mar 15, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 14, 2022

This does a number of things based on review rounds:

  • remove mangled names from any API at all, even tho it was just a name and we could have accepted otehr things, the name was bad
  • move to accepting RemoteCallTarget
  • remove mangledName on and rather provide an unmangled representation if we're able to

TODO: needs more "bad case" tests.

@ktoso ktoso marked this pull request as draft March 14, 2022 12:03
@ktoso
Copy link
Contributor Author

ktoso commented Mar 14, 2022

@swift-ci please smoke test

xedin
xedin approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 15, 2022
@ktoso ktoso force-pushed the wip-abi-cleanup branch from bea4e4b to 4fa0855 Compare March 15, 2022 08:34
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022 •
edited
Loading

Unblocked by swiftlang/swift-syntax#371

ktoso
ktoso commented Mar 15, 2022
View reviewed changes
@ktoso ktoso marked this pull request as ready for review March 15, 2022 08:57
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please smoke test and merge

@ktoso ktoso force-pushed the wip-abi-cleanup branch from 7eef00d to 6caeecd Compare March 15, 2022 14:50
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 4435a37 into swiftlang:main Mar 15, 2022
@ktoso ktoso deleted the wip-abi-cleanup branch March 15, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @xedin @swift-ci