[CMake] Add DEPENDS to dependencies for compiling sources. #5821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. Is this all it was? How did this ever work? cc @erg |
|
A clean build finished successfully with this fix in my environment. Maybe there's some non-determinism? Thanks @rintaro! |
|
@swift-ci Please smoke test |
jrose-apple
approved these changes
Nov 18, 2016
|
For the record: this "ever worked" because the link step depended on the module map but not the compile step. So it was entirely dependent on build order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling
Glibc.swiftdepends onlib/swift/${platform}/${arch}/glibc.modulemapfile.Propagate
DEPENDSargument passed toadd_swift_library()tohandle_swift_sources().Hopefully, fixes SR-3219