Skip to content

[Concurrency] Fix back deploy concurrency threading. #59223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

[Concurrency] Fix back deploy concurrency threading. #59223

merged 1 commit into from
Jun 2, 2022

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Jun 2, 2022

If building the stdlib/runtime is disabled, building BackDeployConcurrency still needs the Threading object library.

@al45tair al45tair requested a review from ahoppen June 2, 2022 09:00
@al45tair
Copy link
Contributor Author

al45tair commented Jun 2, 2022

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

al45tair commented Jun 2, 2022

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS platform

@al45tair
[Concurrency] Fix back deploy concurrency threading.
d3d7f4a 
If building the stdlib/runtime is disabled, building BackDeployConcurrency
still needs the Threading object library.
@al45tair al45tair force-pushed the pr/fix-bdp-threading branch from 91350d6 to d3d7f4a Compare June 2, 2022 13:23
@al45tair
Copy link
Contributor Author

al45tair commented Jun 2, 2022

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS platform

@al45tair
Copy link
Contributor Author

al45tair commented Jun 2, 2022

@swift-ci Please smoke test

@ahoppen ahoppen merged commit 94c9ce6 into swiftlang:main Jun 2, 2022
ahoppen added a commit to ahoppen/swift that referenced this pull request Jun 2, 2022
@ahoppen
Revert "Merge pull request swiftlang#59223 from al45tair/pr/fix-bdp-t…
935e0dd 
…hreading"

This reverts commit 94c9ce6, reversing
changes made to 4967cd5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al45tair @ahoppen