Skip to content

Add regression test for #59467 #60158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add regression test for #59467 #60158

merged 2 commits into from
Jul 20, 2022

Conversation

asl
Copy link
Contributor

@asl asl commented Jul 20, 2022

Pull request #58965 fixed a number of other issues including debug info verification error in #59467. It turned that in the latter the types were queried in the wrong module as typechecking occurred too late.

Resolves #59467

@asl
Copy link
Contributor Author

asl commented Jul 20, 2022

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Jul 20, 2022

Tagging @philipturner @BradLarson

@asl asl requested review from rxwei and dan-zheng July 20, 2022 17:55
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good!

@philipturner
Copy link
Contributor

@asl Thanks!

@asl asl merged commit 8fa3d2f into main Jul 20, 2022
@asl asl deleted the 59467-fix branch July 20, 2022 22:05
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jul 28, 2022
* Add S4TF crasher test
* Unbreak the test

Co-authored-by: Philip Turner <[email protected]>

Resolves swiftlang#59467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AutoDiff][IRGen] Can't compile Swift for TensorFlow on top-of-tree Swift
3 participants