Skip to content

[Autolink Extract] Filter out StringProcessing library from being linked more than once. #62285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Nov 29, 2022

We cannot filter all libraries because duplicate -l flags have a semantic meaning based on their order, but filtering out just the common Swift libraries should yield a good size improvement already and is safe.

@artemcm
Copy link
Contributor Author

artemcm commented Nov 29, 2022

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Nov 29, 2022

Related to #58380

@artemcm artemcm force-pushed the ExpandKnownFilteredAutolinkCommands branch from 390fb1c to a532068 Compare November 29, 2022 23:43
…ked more than once.

We cannot filter all libraries because duplicate -l flags have a semantic meaning based on their order, but filtering out just the common Swift libraries should yield a good size improvement already and is safe.
@artemcm artemcm force-pushed the ExpandKnownFilteredAutolinkCommands branch from a532068 to a69ba3a Compare November 29, 2022 23:44
@artemcm
Copy link
Contributor Author

artemcm commented Nov 29, 2022

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Nov 30, 2022

@swift-ci test macOS platform

@artemcm artemcm requested a review from compnerd November 30, 2022 17:48
@artemcm artemcm merged commit a0ffb8c into swiftlang:main Nov 30, 2022
@artemcm artemcm deleted the ExpandKnownFilteredAutolinkCommands branch November 30, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant