Remove fragile emit-clang-header-nonmodular-includes test #62383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test would break when the SDK changes. The functionality is already tested against the more stable mock-sdk, so the test is being removed entirely.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was meant to check the
-emit-clang-header-nonmodular-includesfunctionality against headers more complicated than the mock-sdk. It was too fragile and would break when the SDK changed. The test is already complicated, trying to handle SDKs for multiple platforms. Rather than try to modify the test to be resilient to SDK changes, I have removed the test entirely.The functionality has been extensively tested on real world projects so I'm confident it works. The other tests introduced in 60971, that test against the more stable mock-sdk, should be enough to prevent regression.