Update store_borrow checking in MemoryLifetimeVerifier and fix ForEachLoopUnroll and GenericCloner #62573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure there are no double end_borrows - Ensure there are no end_borrows after dealloc_stack of the dest
end_borrow should not be inserted after dealloc_stack of the destination
…y cannot be found Make sure end_borrows are inserted before dealloc_stack. Instead of inserting them at function exits. Insert before dealloc_stack of destination.
|
@swift-ci test |
atrick
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating end_borrow of store_borrow after dealloc_stack of its destination. Add verification to raise error in this case and fix ForEachLoopUnroll and GenericCloner where we were doing this.