Add swift:: in a couple of places that don't have using namespace swift (affects sourcekit-lsp) #62583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft (affects sourcekit-lsp)
|
@swift-ci please smoke test |
This was referenced Dec 14, 2022
Merged
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 16, 2022
…ft (affects sourcekit-lsp) (swiftlang#62583)
ando-huang
pushed a commit
to ando-huang/swift
that referenced
this pull request
Jan 2, 2023
…ft (affects sourcekit-lsp) (swiftlang#62583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
swift::in a couple of places that don't haveusing namespace swift(affects sourcekit-lsp.)It didn't catch because those functions are only defined under:
Which the Swift repo doesn't normally build.