[Concurrency] UnownedJob.priority and TaskPriority gains description #63543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
rokhinip,
rjmccall and
DougGregor
and removed request for
rjmccall
ktoso
force-pushed
the
wip-custom-executor-priority
branch
2 times, most recently
from
0ea50ce to
934b0dd
Compare
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-custom-executor-priority
branch
5 times, most recently
from
6c17bb4 to
e5e329d
Compare
ktoso
force-pushed
the
wip-custom-executor-priority
branch
from
e5e329d to
a2783b2
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Custom Executors we should give the executors a chance to know the priority of the Job.
It would be weird to expose a
TaskPriorityonJobsince not all Jobs have to be Tasks. So perhaps this conversion might do the job:UnownedJob.Priority -> TaskPriority?. Open to opinions before I polish this up completely.Worth discussing is that
.priorityperhaps is not saying enough here? As we also haveBasePriorityfor tasks 🤔 Might need some discussion what exactly to expose.We also had an old radar about TaskPriority printing very ugly -- just as the raw value, so this addresses it while working in here with priorities.
Resolves: rdar://103052361 #62430