Skip to content

Conversation

bnbarham
Copy link
Contributor

No description provided.

@bnbarham
Copy link
Contributor Author

@swift-ci please test

@QuietMisdreavus
Copy link
Contributor

This looks really nice! Do you know how something like this will show up in a module-wide symbol graph? Could you add a test to test/SymbolGraph/Symbols that makes sure it shows up properly?

@bnbarham
Copy link
Contributor Author

bnbarham commented Feb 17, 2023

Do you mind if I do that in a separate PR @QuietMisdreavus? I'd like to get the symbol graph response in cursor info ASAP.

Do you know how something like this will show up in a module-wide symbol graph?

I would expect them to, yeah.

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, this looks good on its own.

@bnbarham
Copy link
Contributor Author

Thanks!

@bnbarham bnbarham merged commit b284955 into swiftlang:main Feb 17, 2023
@bnbarham bnbarham deleted the add-sg-macros branch February 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants