[Macros] Fix MacroDecl serialization crash with custom parameter attributes
#63843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
fix-macro-decl-module-crash
branch
2 times, most recently
from
de1cfd2 to
ebe1d2f
Compare
|
@swift-ci please smoke test |
hborla
approved these changes
Feb 22, 2023
…tributes Type-check `MacroDecl`'s parameter list so that custom attributes on parameters will have a type. Fixes a serialization crash.
rxwei
force-pushed
the
fix-macro-decl-module-crash
branch
from
ebe1d2f to
ecc3386
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-check
MacroDecl's parameter list so that custom attributes on parameters will have a type. Fixes a serialization crash.