[Macros] Update executable plugin test to use the python running 'lit' #63888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update 'mock_plugin.py' to support python2 rdar://105870339
|
@swift-ci Please smoke test |
bnbarham
reviewed
Feb 24, 2023
Comment on lines
-24
to
+23
| #!/usr/bin/env python3 | ||
| #!PYTHON_EXEC_PATH |
There was a problem hiding this comment.
Unfortunately I didn't think of this earlier, but using hashbang means that the mock tests will never work on Windows. The only way around that would be to create an actual executable though I think. At least this gets the test working for now, but would be nice if we could come up with something else here.
Ie. we could have a tools/mock-plugin swift library + build that in this test instead.
bnbarham
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update 'mock_plugin.py' to support python2
rdar://105870339