Skip to content

Build: Add build of ASN1 and Certificates for SwiftPM #64087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2023
Merged

Build: Add build of ASN1 and Certificates for SwiftPM #64087

merged 1 commit into from
Mar 4, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Mar 3, 2023

SwiftPM is getting new dependencies, this adds them to the Windows build.

This includes #64045 for the purpose of CI right now

@neonichu neonichu changed the title WIP: Update build with asn1 certs WIP: Build: Add build of ASN1 and Certificates for SwiftPM Mar 3, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023 

cmd.exe /C "cd . && T:\1\bin\swiftc.exe -output-file-map Sources\X509\CMakeFiles\X509.dir\Release\output-file-map.json -incremental -j 36 -emit-library -static -o lib\X509.lib -module-name X509 -module-link-name X509 -emit-module -emit-module-path swift\X509.swiftmodule -emit-dependencies  -O -Xcc -FT:/4 -I T:\4\swift -I T:\12\swift -I C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-crypto\Sources\CCryptoBoringSSL\include -I T:\14\swift @CMakeFiles\X509.rsp   && cd ."
C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-certificates\Sources\X509\Certificate.swift:15:8: error: missing required modules: 'CoreFoundation', 'Dispatch'

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

Ah yah, the swift-certificates CMake build is still broken

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

apple/swift-certificates#33
swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023 

-- Check for working Swift compiler: T:/1/bin/swiftc.exe - works
CMake Error at CMakeLists.txt:24 (find_package):
  Could not find a package configuration file provided by "SwiftSyntax" with
  any of the following names:

    SwiftSyntaxConfig.cmake
    swiftsyntax-config.cmake

  Add the installation prefix of "SwiftSyntax" to CMAKE_PREFIX_PATH or set
  "SwiftSyntax_DIR" to a directory containing one of the above files.  If
  "SwiftSyntax" provides a separate development package or SDK, be sure it
  has been installed.

Probably missed something when re-numbering things.

@neonichu neonichu force-pushed the update-build-with-asn1-certs branch from 2ef62e8 to 5a2a0c6 Compare March 4, 2023 04:01
@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci please smoke test

@neonichu neonichu force-pushed the update-build-with-asn1-certs branch from 5a2a0c6 to 2ca418f Compare March 4, 2023 05:16
@neonichu neonichu changed the title WIP: Build: Add build of ASN1 and Certificates for SwiftPM Build: Add build of ASN1 and Certificates for SwiftPM Mar 4, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci please smoke test windows

@neonichu @compnerd
Build: Add build of ASN1 and Certificates for SwiftPM
e406c2d 
SwiftPM is getting new dependencies, this adds them to the Windows build.

Co-authored-by: Saleem Abdulrasool <[email protected]>
@neonichu neonichu force-pushed the update-build-with-asn1-certs branch from 2ca418f to e406c2d Compare March 4, 2023 06:45
@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 4, 2023

swiftlang/swift-package-manager#6228
@swift-ci Please Build Toolchain Windows Platform

@neonichu neonichu mentioned this pull request Mar 4, 2023
Merged
@compnerd compnerd merged commit 22815bd into swiftlang:main Mar 4, 2023
@neonichu neonichu deleted the update-build-with-asn1-certs branch March 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@tomerd tomerd tomerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @compnerd @tomerd