Honor CMAKE_INSTALL_BINDIR #64281
Closed
Honor CMAKE_INSTALL_BINDIR #64281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Mar 10, 2023
|
CC: @buttaface (might have some thoughts on the install locations) |
finagolfin
reviewed
Mar 11, 2023
tristanlabelle
changed the title
|
The latest commit scopes the PR down to only |
tristanlabelle
changed the title
|
@swift-ci please test |
compnerd
approved these changes
Mar 21, 2023
|
Closing due to age |
|
If you reopen and rebase, I'm sure we could get it in. You're supposed to keep pinging committers, that's the only way I get my pulls in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake install places binaries under the
CMAKE_INSTALL_BINDIRsubdirectory, but some CMake files in this repo hardcodebininstead (the default value). This change un-hardcodes them. This has no effect by default, but it will allow redirecting the binaries to a different output directory, which will help with packaging installers for multiple architectures in the Windows build.A similar change is possible for
CMAKE_INSTALL_LIBDIRandCMAKE_INSTALL_LIBEXECDIRbut I am scoping it out of this PR because of logic to appendLLVM_LIBDIR_SUFFIXto lib directory names.See also:
How tested:
CMAKE_INSTALL_BINDIRto confirm that binaries end up under the specified pathCMAKE_INSTALL_BINDIRto confirm that binaries end up in the same originalbinfolder.