Add -restore to msbuild invocations for Windows installer #64568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with following PRs: @swift-ci please build toolchain windows platform |
tristanlabelle
changed the title
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 23, 2023
|
This should be a no-op as it currently stands, so going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm porting the Windows installer to WiX v4 in this PR: swiftlang/swift-installer-scripts#184 , to stop requiring an installed WiX and support arm64 installers. The updated wixproj depend on Nuget for WiX, so msbuild must be invoked with
-restoreto download any required packages before building. This should be a no-op with the current WiX v3 installer definitions.