[Fix] Main actor in wrong thread #64851
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but I don't think we need this test, we have numerous tests which ensure that code on the @mainactor pass the "is this the main actor executor". It also does not "resolve" #64767 since that might require some detective work if or how something went wrong there. |
ktoso
added
the
concurrency
|
Hi there, I think the main executor is the main thread isn't it? So in that case I need to make a test to ensure it right? if not could you guide me a little bit? Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to this issue #64767. I made a test to be sure if the main actor is in the correct thread or not. It seems to be in the correct one.
Resolves #64767