🍒 "Virtualize swift compiler outputs" #65015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a virutal output backend to capture all the outputs from swift-frontend invocation. This allows redirecting and/or mirroring compiler outputs to multiple location using different OutputBackend. As an example usage for the virtual outputs, teach swift compiler to check its output determinism by running the compiler invocation twice and compare the hash of all its outputs. Virtual output will be used to enable caching in the future.
kavon
requested review from
compnerd,
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov,
xedin,
AnthonyLatsis,
artemcm,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
ktoso,
tshortli,
eeckstein and
shahmishal
as code owners
|
@swift-ci please test |
|
swiftlang/llvm-project#6619 |
|
@kavon can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #63206 had a companion PR swiftlang/llvm-project#6112 that was required because it changed a Swift API (
ASTContext::get). But that same LLVM containing the change is also used byrelease/5.9and the Swift API change was not cherry-picked to therelease/5.9branch. This broke the build and made it difficult to catch-upswift/release/5.9in swiftlang/llvm-project#6619