[CodeCompletion] Enable SwiftParser parsing for code completion #65078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
DougGregor
as code owners
rintaro
force-pushed
the
ide-completion-rdar107900870
branch
from
9ca4ef6 to
53d1a2b
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 11, 2023
ahoppen
approved these changes
Apr 11, 2023
| if (!options::LoadPluginLibrary.empty()) { | ||
| std::vector<std::string> paths; | ||
| for (auto path: options::LoadPluginLibrary) { | ||
| llvm::errs() << "LoadPluginLibrary: " << path << "\n"; |
There was a problem hiding this comment.
Was this just debug output during development or do you want to keep it for the future?
There was a problem hiding this comment.
Argh, I will remove this.
But disable roundtrip/validation testing. So that macro expansions are correctly performed in code completion, but avoid an assertion failure caused by existence of null character in the source buffer. rdar://107900870
rintaro
force-pushed
the
ide-completion-rdar107900870
branch
from
53d1a2b to
f9feee6
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable SwiftParser parsing for code completion, but disable the roundtrip/validation testing. So that macro expansions are correctly performed in code completion, while avoiding an assertion failure
caused by existence of null character in the source buffer.
rdar://107900870