[5.9] test: adjust tests for mandatory tail calls on Win64 #65093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are force enabling the mandatory tail calls on Windows x64, even at the expense of stack traces and debugging support, adjust the tests to account for the difference.
|
@swift-ci test |
eeckstein
changed the title
|
@swift-ci test linux |
|
Do we have the associated changes for this already cherry-picked to 5.9 for llvm? |
|
merging to fix windows CI |
|
@compnerd yes it appears so. these tests were failing because the compiler is now emitting the |
|
specifically, it landed as part of this swiftlang/llvm-project#6619 in this commit: swiftlang/llvm-project@67e69d5 |
|
Awesome, didnt realize it was backported already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are force enabling the mandatory tail calls on Windows x64, even at the expense of stack traces and debugging support, adjust the tests to account for the difference.
This is a cherry-pick of #63660
rdar://107919024