[PrintAsObjC] Special-case <os/object.h> types, like Dispatch. #6544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have historically been defined as protocols in Objective-C (under a pile of macros), but when imported into Swift they're classes instead. Reverse this bit of magic by hard-coding the prefix "OS_" and the header <os/object.h>, and emitting the classic 'foo_bar_t'-style type names. rdar://problem/29790636
jrose-apple
force-pushed
the
PrintAsObjC-os-object-types
branch
from
50867e1 to
e5f0a7b
Compare
milseman
reviewed
Jan 4, 2017
| // CHECK-LABEL: @interface Test : NSObject{{$}} | ||
| public class Test : NSObject { | ||
| // CHECK-NEXT: - (void)thank:(dispatch_queue_t _Nonnull)queue; | ||
| public func thank(_ queue: DispatchQueue) {} |
|
I have to assume no one ever called any of the methods they exposed to Objective-C that involved Dispatch types. Or that people have worked around it in some other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have historically been defined as protocols in Objective-C (under a pile of macros), but when imported into Swift they're classes instead. Reverse this bit of magic by hard-coding the prefix "OS_" and the header
<os/object.h>, and emitting the classicfoo_bar_t-style type names.rdar://problem/29790636