Skip to content

[Distributed] Relax ordering of checks in async_taskgroup_discarding_dontLeak #66166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 26, 2023

Since it seems the deinits may not necessarily run in expected order sometimes, but they do all run.

Follow up to #65613 and already included in the 5.9 cherry pick

expected order; but as long as they all run we're happy
@ktoso
Copy link
Contributor Author

ktoso commented May 26, 2023

@swift-ci please smoke test and merge

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label May 26, 2023
@ktoso ktoso changed the title [Distributed] Relax ordering of checks in test [Distributed] Relax ordering of checks in async_taskgroup_discarding_dontLeak May 26, 2023
@swift-ci swift-ci merged commit 44e1995 into swiftlang:main May 26, 2023
@ktoso ktoso deleted the wip-discarding-error-task-leak branch May 26, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants