[Macros] Add default plugin paths for Darwin SDKs and platforms. #66711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
bnbarham
reviewed
Jun 16, 2023
lib/Driver/DarwinToolChains.cpp
Outdated
| @@ -694,7 +739,7 @@ toolchains::Darwin::constructInvocation(const DynamicLinkJobAction &job, | |||
| } | |||
|
|
|||
| if (context.Args.hasArg(options::OPT_enable_app_extension)) { | |||
| // Keep this string fixed in case the option used by the | |||
| // Keep this string fixed in case the option used by thez | |||
Corresponding to swiftlang/swift-driver#1377, this adds some default plugin paths for Darwin SDKs and platforms. Fixes rdar://110819604.
DougGregor
force-pushed
the
old-driver-default-plugin-paths
branch
from
a934d5c to
1ec900e
Compare
|
Already fully testing except for fixing a comment typo. Forcing rather than going through another multi-hour CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to swiftlang/swift-driver#1377, this adds some default plugin paths for Darwin SDKs and platforms. Fixes rdar://110819604.