5.9: [TypeLowering] Move-only types are lexical. #66717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vars of such types should be given lexical `alloc_stack`s by `AllocBoxToStack` which requires that the `alloc_box` insts formed for them have an associated borrow scope which in turn requires that type lowering for move only structs and enums have their lexical bits set. rdar://110901430
|
@swift-ci please test |
tbkka
approved these changes
Jun 16, 2023
|
Added NFC commit from main that prints out the fields in TypeLowering that were previously omitted (and which the test here is checking). |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix TypeLowering of move-only types to have the lexical bit set.
Whether a value gets a lexical lifetime is deterimined by a few factors, among them, whether the type is lexical--to a first level of approximation, whether the type has any non-trivial fields that aren't explicity eager-move. Move-only types already have the non-trivial bit set. They need also to have the lexical bit set.
Risk: Low. The fix is very simple, two lines of code, just setting the lexical bits on move-only types.
Scope: Narrow. This only affects move-only types.
Original PR: #66705
Reviewed By: Andrew Trick ( @atrick )
Testing: Added test case illustrating that a move-only type is lexical.
Resolves: rdar://110901430