Skip to content

[🍒][nfc][cxx-interop] Remove NS(U)Integer typedefs from a test. #66646 #66962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zoecarver
Copy link
Contributor

Explanation: Using NS(U)Integer is not portable so we should avoid using it where possible.
Scope: C++ interoperability test
Risk: none/test only change.
Testing: Swift unit tests.
PR: #66646

@zoecarver zoecarver requested a review from a team as a code owner June 27, 2023 19:23
@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@ravikandhadai ravikandhadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zoe!

@zoecarver
Copy link
Contributor Author

@swift-ci please test

@zoecarver
Copy link
Contributor Author

@swift-ci please test macOS

@zoecarver zoecarver merged commit 7b968d6 into swiftlang:release/5.9 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants