[CSBindings] Prefer conjunctions over closure variables without bindings #67441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
If a closure doesn't have a contextual type inferred yet it should be delayed in favor of already resolved closure conjunction because "resolving" such a closure early could miss result builder attribute attached to a parameter the closure is passed to. Partially resolves swiftlang#67363
xedin
force-pushed
the
fix-overly-eager-closure-resolving
branch
from
cfa3b29 to
11ee82d
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility release |
|
Release source compat failures are unrelated and happen on main as well - |
|
@swift-ci please test source compatibility release |
hborla
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a closure doesn't have a contextual type inferred yet it should be delayed in favor of
already resolved closure conjunction because "resolving" such a closure early could
miss result builder attribute attached to a parameter the closure is passed to.
Partially resolves #67363