[IRGen] Other instructions whose ops/results have packs may allocate pack metadata. #67569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it's a tuple containing a pack.
Add the recursive property.
nate-chandler
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test linux platform |
slavapestov
reviewed
Jul 27, 2023
lib/AST/Type.cpp
Outdated
| RecursiveTypeProperties::HasArchetype, InterfaceType, | ||
| ConformsTo, Superclass, Layout, GenericEnv) { | ||
| RecursiveTypeProperties::HasArchetype | | ||
| RecursiveTypeProperties::HasConcretePack, |
There was a problem hiding this comment.
It’s actually PackExpansionType that leads us into this situation
There was a problem hiding this comment.
Yeah, it's a PackExpansionType whose pattern is a PackArchetypeType:
(tuple_type num_elements=1
(tuple_type_elt
(pack_expansion_type
(pattern=pack_archetype_type address=0x127045b10
(interface_type=dependent_member_type assoc_type=Swift.(file).Sequence.Element
(base=generic_type_param_type depth=0 index=0 decl=main.(file).tupleExpansionWithMemberType(seqs:elts:)[email protected]:1:47 pack)) name=(each T).Element
)
(count=pack_archetype_type address=0x127045880
(interface_type=generic_type_param_type depth=0 index=0 decl=main.(file).tupleExpansionWithMemberType(seqs:elts:)[email protected]:1:47 pack) conforms_to=Swift.(file).Sequence name=each T
))))
Eliminated HasConcretePack and added HasPack and HasPackArchetype. Renamed the old `hasPack` to `hasAnyPack`; as before, it means that the type has a parameter pack, a pack, or a pack archetype.
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar112792831-3
branch
from
b4f32b4 to
b0911d1
Compare
Instead of assuming that the list of instructions known to allocate pack metadata is exhaustive and returning false from mayRequirePackMetadata for all others, consider the types of the results and operands of other instructions and look for packs.
nate-chandler
force-pushed
the
rdar112792831-3
branch
from
b0911d1 to
928bcf3
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #67567 .
Instead of assuming that the list of instructions known to allocate pack metadata is exhaustive and returning false from mayRequirePackMetadata for all others, consider the types of the results and operands of other instructions and look for packs.