[CodeComplete] Avoid dropping "is for code completion" bit #67626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤞 |
hamishknight
force-pushed
the
try-without-completion-drop
branch
from
2ef4564 to
c8c2abc
Compare
This should no longer be needed now that we check for a code completion token when increasing the score. It should also allow us to skip more conjunction elements, as that requires the bit being set.
hamishknight
force-pushed
the
try-without-completion-drop
branch
from
c8c2abc to
6ede5e0
Compare
hamishknight
changed the title
|
@swift-ci please test |
|
The stress tester run didn't show any measurable performance impact |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should no longer be needed now that we check for a code completion token when increasing the score. It should also allow us to skip more conjunction elements, as that requires the bit being set.