Skip to content

[IRGen] Exiting terminators don't alloc packs. #67778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nate-chandler
Copy link
Contributor

Function exiting terminators don't allocate on-stack pack metadata packs. The packs would have been materialized when the value is defined.

Fixes a SILVerifier failure resulting from a sequence like

alloc_pack_metadata
dealloc_pack_metadata
return

resulting from inserting the alloc_pack_metadata on behalf of the return, inserting the dealloc_pack_metadata on the dominance frontier, and fixing up stack nesting.

Function exiting terminators don't allocate on-stack pack metadata
packs.  The packs would have been materialized when the value is
defined.

Fixes a SILVerifier failure resulting from a sequence like
```
alloc_pack_metadata
dealloc_pack_metadata
return
```
resulting from inserting the `alloc_pack_metadata` on behalf of the
return, inserting the `dealloc_pack_metadata` on the dominance frontier,
and fixing up stack nesting.
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler merged commit 5024014 into swiftlang:main Aug 8, 2023
@nate-chandler nate-chandler deleted the rdar112792831-4 branch August 8, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant