[IRGen] Exiting terminators don't alloc packs. #67778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function exiting terminators don't allocate on-stack pack metadata packs. The packs would have been materialized when the value is defined. Fixes a SILVerifier failure resulting from a sequence like ``` alloc_pack_metadata dealloc_pack_metadata return ``` resulting from inserting the `alloc_pack_metadata` on behalf of the return, inserting the `dealloc_pack_metadata` on the dominance frontier, and fixing up stack nesting.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function exiting terminators don't allocate on-stack pack metadata packs. The packs would have been materialized when the value is defined.
Fixes a SILVerifier failure resulting from a sequence like
resulting from inserting the
alloc_pack_metadataon behalf of the return, inserting thedealloc_pack_metadataon the dominance frontier, and fixing up stack nesting.