Skip to content

Cxx: build Cxx module statically on all platforms #68161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

compnerd
Copy link
Member

This adjusts Cxx to be built statically on all platforms including Windows. The static library support is sufficient to support this module linking statically on Windows.

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-installer-scripts#231

@swift-ci please test

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-installer-scripts#231

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-installer-scripts#231

@swift-ci please clean test Linux platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-installer-scripts#231

@swift-ci please clean test macOS platform

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks great. One comment about why I think it's crashing...

This adjusts Cxx to be built statically on all platforms including
Windows.  The static library support is sufficient to support this
module linking statically on Windows.
@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-installer-scripts#231

@swift-ci please test

@compnerd compnerd merged commit 1305901 into swiftlang:main Aug 28, 2023
@compnerd compnerd deleted the static-cxx branch August 28, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants