swift-plugin-server: adjust API for portability #68268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
reinventing-the-wheel-poorly
branch
from
b876369 to
d2f46c5
Compare
This begins reworking the API to be less POSIX centric and more generally usable. The API was defined in terms of `dlopen`/`dlsym` rather than the better suited `llvm::sys::DynamicLibrary` APIs which would avoid most of the work that needs to be done here for platform specifics.
compnerd
force-pushed
the
reinventing-the-wheel-poorly
branch
from
d2f46c5 to
c6222bf
Compare
|
@swift-ci please test |
Include `stdint.h` for non-MSVC compilers.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins reworking the API to be less POSIX centric and more generally usable. The API was defined in terms of
dlopen/dlsymrather than the better suitedllvm::sys::DynamicLibraryAPIs which would avoid most of the work that needs to be done here for platform specifics. Prefer to guard that with_WIN32until this is fully tested on Windows.