[CSBindings] Delay default binding production until inference is exhausted #68317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usted Previously, default bindings (from Defaultable and FallbackType constraints) where added to the set right after the first attempt, but that is incorrect because binding producer should exhaust the chain of superclasses and other "inferred" bindings first or risk producing subpar solutions.
|
cc @amritpan |
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, default bindings (from Defaultable and FallbackType constraints)
where added to the set right after the first attempt, but that is incorrect because
binding producer should exhaust the chain of superclasses and other "inferred"
bindings first or risk producing subpar solutions.