nonisolated(unsafe) to opt out of strict concurrency static checking for global variables #69280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
requested review from
ktoso,
kavon,
slavapestov,
hborla,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
hamishknight,
zoecarver,
hyp and
egorzhdan
as code owners
sophiapoirier
requested review from
DougGregor,
rjmccall and
kavon
and removed request for
xedin,
slavapestov,
ktoso,
rintaro,
kavon,
hyp,
DougGregor,
bnbarham,
CodaFi,
egorzhdan,
ahoppen,
zoecarver and
hamishknight
sophiapoirier
force-pushed
the
globals_strict_concurrency_opt_out_nonisolated_unsafe
branch
from
4155d24 to
1e1eb80
Compare
xedin
reviewed
Oct 23, 2023
| @@ -7832,6 +7833,14 @@ VarDecl *VarDecl::getLazyStorageProperty() const { | |||
| {}); | |||
| } | |||
|
|
|||
| bool VarDecl::isGlobalStorage() const { | |||
| if (!hasStorage()) { | |||
There was a problem hiding this comment.
Should this be hasStorageOrWrapsStorage()? I wonder how this interacts with property wrapped static properties...
There was a problem hiding this comment.
Thanks @xedin good point, and I addressed property wrapped static properties in the most recent commit.
sophiapoirier
force-pushed
the
globals_strict_concurrency_opt_out_nonisolated_unsafe
branch
3 times, most recently
from
20528a0 to
1468b07
Compare
xedin
approved these changes
Oct 26, 2023
…for global variables
sophiapoirier
force-pushed
the
globals_strict_concurrency_opt_out_nonisolated_unsafe
branch
from
cb1a2f8 to
4c9a726
Compare
|
@swift-ci please test |
sophiapoirier
deleted the
globals_strict_concurrency_opt_out_nonisolated_unsafe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up based on feedback from the pitch for strict concurrency for global variables that there is need for an opt-out mechanism when thread-safety is manually managed.