[VIM] Fix syntax highlighting of nested comments #69461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example incorrectly highlights 'foo' as a comment: /* // */ foo This example does as well: // /* foo */ foo
compnerd
reviewed
Oct 31, 2023
compnerd
approved these changes
Oct 31, 2023
|
@swift-ci please smoke test |
|
Thanks for the contribution @capricorn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes incorrect vim syntax highlighting of some comments. The following examples incorrectly highlight
fooas a comment.This was previously fixed in fea0f4d but was a regression introduced in 633986e.
The simplest test is to place the two syntax files of
swift.vim, before and after this change, into~/.vim/syntaxwith unique names, open the above comments in vim and then toggle between them with eg:set syntax=swiftfix.vim.