build: update build.ps1, use update-checkout for more dependencies #69555
Conversation
|
@swift-ci please build toolchain Windows platform |
|
@swift-ci please build toolchain Windows platform |
|
@parkera @iCharlesHu Are you ok with updating ICU tag to |
|
@compnerd is there a way to verify that swift-corelibs-foundation's unit tests still pass with the updated ICU? Sometimes updates to formatting styles and such can cause issues. |
If Windows has always used 69 I don't see an issue. Although I'd say we should definitely test swift-corelibs-foundation to make sure the new ICU doesn't break things. In the past we've seen ICU change things (like the separator it uses etc) between releases so this could break some tests. |
|
@iCharlesHu, yeah, we have always used 69.1 for Windows. @parkera, I can stack the change to get ICU switched over to 69.1 and do a cross-repository test for Linux. I know that the build on Windows will also test Foundation as well. |
Update the build.ps1 to match the current state which introduces `-BuildTo` and updates most of the dependencies. Take the opportunity to migrate to update-checkout for the majority of the dependencies. The SQLite amalgamation and installer image are still fetched later, and ICU is still cloned in the CI wrapper.
Unify the non-Darwin targets to ICU 69. Windows has been using ICU 69 since 5.3, Linux was at 65.
Update next to match main for dependencies. This includes: - CURL - ICU - libxml2 - zlib
|
@swift-ci please test |
|
@parkera https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/306/ is the test run - seems that it doesn't impact the tests. |
|
We will need to have these changes cherry-picked into release/5.10. |
|
@shahmishal I think that we want to get the changes into main and then cherry-pick. I can prepare a cherry-pick before it is merged of course if you prefer. |
@compnerd It can be done after, just wanted to make sure we cherry-pick these changes to support the nightly toolchain for release/5.10. |
| "curl": { | ||
| "remote": { "id": "curl/curl" } | ||
| }, | ||
| "libxml2": { | ||
| "remote": { "id": "gnome/libxml2" } | ||
| }, | ||
| "zlib": { | ||
| "remote": { "id": "madler/zlib" } | ||
| } |
There was a problem hiding this comment.
Why do we suddenly need these, and icu, on macOS?
|
No, this only adds the repositories to the set, it doesn't write files into it. |
Update the build.ps1 to match the current state which introduces
-BuildToand updates most of the dependencies. Take the opportunity to migrate to update-checkout for the majority of the dependencies. The SQLite amalgamation and installer image are still fetched later, and ICU is still cloned in the CI wrapper.