Update mixin_swiftpm_base to include swift-driver #69696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the base spm preset to include building an installing the swift driver. This ensures that ci jobs properly use the new driver instead of the to-be-removed c++ version.
|
@swift-ci please test |
MaxDesiatov
approved these changes
Nov 7, 2023
artemcm
approved these changes
Nov 7, 2023
|
@swift-ci please smoke test |
|
I believe I tried this before and it didn't work, see #61766 |
|
@neonichu is this still true: swiftlang/swift-package-manager#5842 (comment)? I thought some things had changed wrt now needing swift to build swift? |
|
Unlike that PR this one has CI checks green, so maybe things have changed enough for this to be ok? |
Unclear, it seems like this PR is a needed first step but won't fix the issue where SPM is built and tested before swift-driver is built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the base spm preset to include building and installing the swift driver. This ensures that ci jobs properly use the new driver instead of the to-be-removed c++ version.
Fixes the issue with the spm LTO test fixture on linux here: swiftlang/swift-package-manager#6891