Skip to content

[5.10] Move swift-parser-cli to its own package #69963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2023
Merged

[5.10] Move swift-parser-cli to its own package #69963

merged 1 commit into from
Nov 29, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 17, 2023

Cherry-pick #68120 to release/5.10.

Companion of swiftlang/swift-syntax#2346

  • Explanation: [5.10] Cherry-pick multiple PRs to release/5.10 swift-syntax#2346 moves the swift-parser-cli tool to a separate package so that swift-syntax no longer has a dependency on swift-argument-parser. For this to work, the new package needs to be included in the multi root data file.
  • Scope: Build infrastructure
  • Risk: Low
  • Testing: Test that the project still builds
  • Issue: n/a
  • Reviewer: @ahoppen

@ahoppen ahoppen requested a review from a team as a code owner November 17, 2023 17:53
@ahoppen ahoppen mentioned this pull request Nov 17, 2023
Merged
@ahoppen
Copy link
Member Author

ahoppen commented Nov 28, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge November 28, 2023 23:47
@ahoppen
Copy link
Member Author

ahoppen commented Nov 29, 2023

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 04e0e9e into swiftlang:release/5.10 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @bnbarham @StevenWong12