Skip to content

docs: improve withTaskCancellationHandler docs #70035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2023
Merged

docs: improve withTaskCancellationHandler docs #70035

merged 5 commits into from
Nov 28, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Nov 27, 2023

Docs improvements.

Also removes two places where we had deprecation warnings and can avoid them.

Please review @etcwilde @amartini51

Resolves rdar://117284404

@ktoso ktoso requested review from etcwilde and amartini51 November 27, 2023 07:54
@ktoso ktoso requested a review from kavon as a code owner November 27, 2023 07:54
@ktoso
Copy link
Contributor Author

ktoso commented Nov 27, 2023

@swift-ci please smoke test

amartini51
amartini51 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@amartini51 amartini51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor style corrections — these improvements look good to me.

@ktoso ktoso enabled auto-merge (squash) November 27, 2023 21:47
@ktoso
Copy link
Contributor Author

ktoso commented Nov 27, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2023 


<unknown>:0: note: No available targets are compatible with triple "riscv64-none-none-eabi"
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.	<eof> parser at end of file
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x000000011060bfc7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39

trying again

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2023

@swift-ci please smoke test macOS

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2023

Pending on #70057 to unbreak CI

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2023

@swift-ci please smoke test

@ktoso ktoso merged commit c468479 into swiftlang:main Nov 28, 2023
@ktoso ktoso deleted the docs-better-withCancellation-docs branch November 29, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartini51 amartini51 amartini51 approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

@kavon kavon Awaiting requested review from kavon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @amartini51