[embedded] Make embedded target triples conditional on LLVM support #70218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM might not be build with support for all architectures to save time. The changes in this commit check the value of LLVM_TARGETS_TO_BUILD provided by LLVMConfig.cmake to add or skip the different embedded targets if LLVM happens to not build with support for that target. While x86_64 and ARM/AArch64 are very common in `LLVM_TARGETS_TO_BUILD`, targets like RISCV are more specialized and might not be always enabled. This is not a problem for builds using the `build-script` because of the changes introduced in swiftlang#70057, but it is still a problem for other builds that do not use `build-script`. This solution should work for any build.
phausler
reviewed
Dec 5, 2023
| "riscv32 riscv32-none-none-eabi riscv32-none-none-eabi" | ||
| "riscv64 riscv64-none-none-eabi riscv64-none-none-eabi" | ||
| set(EMBEDDED_STDLIB_TARGET_TRIPLES) | ||
| if("ARM" IN_LIST LLVM_TARGETS_TO_BUILD) |
There was a problem hiding this comment.
does this catch when we specify --llvm-targets-to-build all?
There was a problem hiding this comment.
It should. all is already the default, and it is transformed in https://github.com/apple/llvm-project/blob/94624bdf65b8ad61f9bf3948a5bf387c6fa0a967/llvm/CMakeLists.txt#L569-L571 to expand to the actual list. One never has to check for "all" explicitly.
kubamracek
approved these changes
Dec 5, 2023
|
@swift-ci please test |
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…wiftlang#70218) LLVM might not be build with support for all architectures to save time. The changes in this commit check the value of LLVM_TARGETS_TO_BUILD provided by LLVMConfig.cmake to add or skip the different embedded targets if LLVM happens to not build with support for that target. While x86_64 and ARM/AArch64 are very common in `LLVM_TARGETS_TO_BUILD`, targets like RISCV are more specialized and might not be always enabled. This is not a problem for builds using the `build-script` because of the changes introduced in swiftlang#70057, but it is still a problem for other builds that do not use `build-script`. This solution should work for any build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM might not be build with support for all architectures to save time. The changes in this commit check the value of LLVM_TARGETS_TO_BUILD provided by LLVMConfig.cmake to add or skip the different embedded targets if LLVM happens to not build with support for that target.
While x86_64 and ARM/AArch64 are very common in
LLVM_TARGETS_TO_BUILD, targets like RISCV are more specialized and might not be always enabled.This is not a problem for builds using the
build-scriptbecause of the changes introduced in #70057, but it is still a problem for other builds that do not usebuild-script. This solution should work for any build.